Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt: Implement "Movie" menu #5988

Merged
merged 3 commits into from Sep 3, 2017
Merged

Qt: Implement "Movie" menu #5988

merged 3 commits into from Sep 3, 2017

Conversation

spycrab
Copy link
Contributor

@spycrab spycrab commented Aug 27, 2017

No description provided.

@spycrab
Copy link
Contributor Author

spycrab commented Aug 27, 2017

@ligfx @MayImilae @JMC47

@spycrab spycrab force-pushed the qt_movie branch 3 times, most recently from cc04a40 to 6316b29 Compare September 2, 2017 11:54
delroth
delroth requested changes Sep 2, 2017
View reviewed changes
Copy link
Member

@delroth delroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks, but that's what I do best.

Source/Core/DolphinQt2/MainWindow.h
@@ -105,6 +105,12 @@ class MainWindow final : public QMainWindow

void OnBootGameCubeIPL(DiscIO::Region region);

This comment was marked as off-topic.

Sign in to view

Source/Core/DolphinQt2/MenuBar.h Outdated
@@ -26,6 +28,9 @@ class MenuBar final : public QMenuBar
void EmulationStopped();
void UpdateStateSlotMenu();
void UpdateToolsMenu(bool emulation_started);
void UpdateSelection(QSharedPointer<GameFile> game_file);

This comment was marked as off-topic.

Sign in to view

@delroth delroth merged commit 632cb35 into dolphin-emu:master Sep 3, 2017
@spycrab spycrab deleted the qt_movie branch September 3, 2017 01:15
@leoetlino leoetlino modified the milestone: Qt Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delroth delroth delroth requested changes

Assignees
No one assigned
Labels
None yet
Milestone
Qt
3 participants
@spycrab @delroth @leoetlino