Qt: Support versions < 5.6 #6008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spycrab
force-pushed
the
qt_older
branch
2 times, most recently
from
a4e5f9d
to
cbdd649
Compare
spycrab
force-pushed
the
qt_older
branch
2 times, most recently
from
c2b1a47
to
db91a67
Compare
ligfx
suggested changes
Sep 4, 2017
There was a problem hiding this comment.
Looks good, one main thing:
- What does initializing a QKeySequence with zero mean? Should it be default-initialized instead?
and two small things:
addMenuActionandaddToolActioncould probably be combined and extracted into some QtUtils header- Dolphin style guide says function namss should start with an uppercase letter
spycrab
force-pushed
the
qt_older
branch
3 times, most recently
from
ea0e1b2
to
bdbbdb9
Compare
ligfx
reviewed
Sep 4, 2017
Source/Core/CMakeLists.txt
Outdated
| if(ENABLE_QT2) | ||
| add_subdirectory(DolphinQt2) | ||
| endif() | ||
| add_subdirectory(DolphinQt2) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
For the record: All buildbots have passed when forced to compile DolphinQt2:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.