Remove Symbol Address Mask #6054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upper 4 bits were masked out of function addresses prior when generating symbols.
|
What does this fix? |
|
it enables the full address of the symbols to be shown |
|
SGTM. I'm pretty sure I've seen cases where symbols were overlapping for games. I think the Netflix channel was one of them. |
|
did they share the same virtual address |
|
@gamemasterplc I don't think so. It was loading stuff around 0x7??????? which could clash with 0x80000000 symbols. |
|
probably that same MMU trick that star wars uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upper 4 bits were masked out of symbol addresses before when generating symbols.