Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NANDImporter: Add support for dumps that don't include keys #6144

Merged
merged 1 commit into from
Oct 29, 2017

Conversation

leoetlino
Copy link
Member

This adds support for NAND images that only include the NAND (i.e. without the OTP/SEEPROM dump appended at the end of the file).

@leoetlino leoetlino changed the title NANDImporter: Add support for NAND only images NANDImporter: Add support for dumps that don't include keys Oct 26, 2017
Copy link
Member

@BhaaLseN BhaaLseN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good other than the file-picker comments; but those might even be non-issues...

return RunOnObject(this, [this] {
return QFileDialog::getOpenFileName(this, tr("Select the OTP/SEEPROM dump"),
QDir::currentPath(),
tr("BootMii OTP/SEEPROM dump (*.bin);;"

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

[this] {
return WxStrToStr(wxFileSelector(
_("Select the OTP/SEEPROM dump"), wxEmptyString, wxEmptyString, wxEmptyString,
_("BootMii OTP/SEEPROM dump (*.bin)") + "|*.bin|" + wxGetTranslation(wxALL_FILES),

This comment was marked as off-topic.

This comment was marked as off-topic.

This adds support for NAND images that only include the NAND
(i.e. without the OTP/SEEPROM dump appended at the end of the file).
@leoetlino leoetlino merged commit 201ce4b into dolphin-emu:master Oct 29, 2017
@leoetlino leoetlino deleted the nand-import-fix branch October 29, 2017 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants