Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show "N/A" as description when there is no Gecko code #6160

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

JosJuice
Copy link
Member

@JosJuice JosJuice commented Nov 2, 2017

"N/A" can be awkward to handle in translations.

I don't think there's much point in showing "N/A" rather than leaving the description box blank, so let's just leave it blank.

"N/A" can be awkward to handle in translations.

I don't think there's much point in showing "N/A" rather than
leaving the description box blank, so let's just leave it blank.
Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. WX does not do this either.

@leoetlino leoetlino merged commit 9e4590b into dolphin-emu:master Nov 3, 2017
@JosJuice JosJuice deleted the gecko-na branch November 3, 2017 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants