Fixed Frame dumping in VideoSoftware. #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dolphin-emu-bot rebuild |
| delete[] data; | ||
| static void DumpColorTexture(const std::string& filename, u32 width, u32 height) | ||
| { | ||
| (void)TextureToPng(SWRenderer::getCurrentColorTexture(), width * 4, filename, width, height, true); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@neobrain can you quickly review this? it's short and would allow fifocisw :) |
|
If this works, LGTM. |
|
@phire: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge. @phire if you've tested it and it works with both bypass XFB (required for FIFO logs) and standard XFB handling, feel free to merge. @dolphin-emu-bot allowmerge |
Old code dumped the efb, which was no-longer relevant since the backend gained xfb support. New code dumps the colour texture which is about to be rendered to the screen so correctly reflects the bypassXFB option.
|
Yep, Both bypass and standard work. Merging |
dolphin-emu-bot
added a commit
that referenced
this pull request
Jul 17, 2014
Fixed Frame dumping in VideoSoftware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old code dumped the efb, which was no-longer relevant since the backend gained xfb support.
New code dumps the colour texture which is about to be rendered to the screen so correctly reflects the bypassXFB option.