Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Qt/Wx: Turn Qt into the default interface #6331

Merged
merged 1 commit into from
Apr 21, 2018
Merged

[RFC] Qt/Wx: Turn Qt into the default interface #6331

merged 1 commit into from
Apr 21, 2018

Conversation

spycrab
Copy link
Contributor

@spycrab spycrab commented Jan 26, 2018 •
edited
Loading

Also see the Qt feature report.

@leoetlino leoetlino added the WIP / do not merge Work in progress (do not merge) label Jan 26, 2018
@MayImilae
Copy link
Contributor

MayImilae commented Jan 26, 2018 •
edited
Loading

When are you planning to start pushing this for merging? A lot of features are still missing!

@spycrab
Copy link
Contributor Author

spycrab commented Jan 26, 2018

When Qt is feature-complete (so approximately this summer).

@spycrab spycrab force-pushed the deprecate_wx branch 3 times, most recently from a20047f to 25986c7 Compare January 26, 2018 11:55
@spycrab
Copy link
Contributor Author

spycrab commented Jan 26, 2018

This PR breaks the windows buildbots atm, closing it for now.

@spycrab spycrab closed this Jan 26, 2018
@spycrab
Copy link
Contributor Author

spycrab commented Apr 13, 2018

Here we go again.

@spycrab spycrab reopened this Apr 13, 2018
@spycrab spycrab force-pushed the deprecate_wx branch 4 times, most recently from acd5202 to 47e7cfb Compare April 13, 2018 19:42
BhaaLseN
BhaaLseN reviewed Apr 13, 2018
View reviewed changes
Source/Core/DolphinQt2/CMakeLists.txt Outdated
PRIVATE
core
Qt5::Widgets
uicommon
)

set(DOLPHINQT2_BINARY dolphin-emu)

This comment was marked as off-topic.

Sign in to view

@spycrab spycrab changed the title [WIP] Qt/Wx: Turn Qt into the default interface [RFC] Qt/Wx: Turn Qt into the default interface Apr 13, 2018
@leoetlino leoetlino removed the WIP / do not merge Work in progress (do not merge) label Apr 13, 2018
@spycrab
Copy link
Contributor Author

spycrab commented Apr 13, 2018

@MayImilae @JMC47

@MayImilae
Copy link
Contributor

MayImilae commented Apr 16, 2018 •
edited
Loading

When #6650 and #6659 are merged, I think it's time to do this! Qt has come along SO far, and not only is it at parity (well almost, those two missing things :P) with WX, but it's better in a lot of ways!

@leoetlino leoetlino added this to the Qt milestone Apr 19, 2018
@autofire372
Copy link
Contributor

This still isn't building for Windows...

@spycrab
Copy link
Contributor Author

spycrab commented Apr 20, 2018

It does. The buildbot just needs to do a clean rebuild once.

@spycrab spycrab force-pushed the deprecate_wx branch 2 times, most recently from e1586ce to 2482bc5 Compare April 21, 2018 15:47
@leoetlino leoetlino merged commit 9dcc813 into dolphin-emu:master Apr 21, 2018
@spycrab spycrab deleted the deprecate_wx branch April 21, 2018 16:43
ghost referenced this pull request Apr 23, 2018
@JosJuice
Translation resources sync with Transifex
c51c044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BhaaLseN BhaaLseN BhaaLseN left review comments

@MayImilae MayImilae MayImilae approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
Qt
5 participants
@spycrab @MayImilae @autofire372 @BhaaLseN @leoetlino