Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt/PropertiesDialog: Implement "Patches" tab #6382

Merged
merged 1 commit into from
Mar 2, 2018

Conversation

spycrab
Copy link
Contributor

@spycrab spycrab commented Feb 16, 2018

Screenshots:
Screenshot
Screenshot

@spycrab spycrab force-pushed the qt_patches branch 3 times, most recently from 99178b7 to 8773761 Compare February 16, 2018 14:08
@spycrab
Copy link
Contributor Author

spycrab commented Feb 16, 2018

@JMC47 @MayImilae

@BhaaLseN
Copy link
Member

BhaaLseN commented Feb 16, 2018

Does Qt have an equivalent to WinForms Flow layout or WPF Wrap Panel? Thinking along the lines of this:
WPF WrapPanel

Something that horizontally aligns item as long as they fit and wrap onto a new line once they don't.
That small window with the scrollbar kind of bothers me a little; but I can live with it when the usual case is one (or perhaps two) entry per patch.

Google seems to like this page; but I don't know if that works with our Qt version: http://doc.qt.io/qt-5/qtwidgets-layouts-flowlayout-example.html

@spycrab
Copy link
Contributor Author

spycrab commented Feb 16, 2018

I'd have to ask what @MayImilae and @JMC47 think of that.

@MayImilae
Copy link
Contributor

To be honest, the only patch I can find is the Hyrule Speed Hack. I don't know of any other!

As such... I don't think we need to do anything fancy here. Having anything more than one is very unlikely.

@spycrab
Copy link
Contributor Author

spycrab commented Feb 20, 2018

So any of you two wanna test this? @MayImilae @JMC47

std::vector<PatchEngine::Patch> m_patches;
const GameFile& m_game;
std::string m_game_id;
u8 m_game_revision;

This comment was marked as off-topic.

@JMC47
Copy link
Contributor

JMC47 commented Mar 1, 2018

It works as well as the WX Patches Window. The sizing is a bit weird in spots, but it's definitely less ugly than the other solution in WX.

@Helios747 Helios747 merged commit 78b00d8 into dolphin-emu:master Mar 2, 2018
@spycrab spycrab deleted the qt_patches branch March 2, 2018 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants