ShaderCache: Fix several issues in background shader compiling #6430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
degasus
reviewed
Mar 14, 2018
| std::unique_ptr<AbstractPipeline> pipeline; | ||
| std::optional<AbstractPipelineConfig> pipeline_config = GetGXPipelineConfig(uid); | ||
| if (pipeline_config) | ||
| pipeline = g_renderer->CreatePipeline(*pipeline_config); | ||
| if (g_ActiveConfig.bShaderCache) | ||
| if (g_ActiveConfig.bShaderCache && !exists_in_cache) | ||
| AppendGXPipelineUID(uid); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
- In D3D, shaders could be compiled on the main thread, blocking startup. - Reduced the latency between a pipeline being requested and used in all backends in hybrid ubershader mode, when no shader stages were present. - Fixed a case where async compilation could cause the same UID to be appended multiple times to the UID cache. - Fix incorrect number of threads being used when immediately compile shaders was enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some bugs in the videocommon shader cache which managed to sneak in. None of these are really noticeable unless you're looking at the internal state of the shader cache, but are still important nonetheless.