GLInterface: Use EXT_swap_control or MESA_swap_control over SGI #6536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SGI extension does not define calling SwapInterval with a parameter of zero as valid. It was just lucky that drivers interpreted this as vsync off. The EXT_swap_control extension defines zero as a valid value. Mesa does not appear to support the EXT variant, so we fall back to MESA_swap_control here, which also supports zero.
linkmauve
approved these changes
Mar 26, 2018
|
Also tested on NVIDIA's binary driver and radeonsi. Only driver left is fglrx/radeongpu-pro, but does anyone use that with Dolphin? Either way, I don't have hardware which can run that driver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SGI extension does not define calling SwapInterval with a parameter of zero as valid. It was just lucky that drivers interpreted this as vsync off. The EXT_swap_control extension defines zero as a valid value.
Mesa does not appear to support the EXT variant, so we fall back to MESA_swap_control here, which also supports zero.
Fixes the frame rate being capped at the screen refresh rate without using vblank_mode=0 in Mesa.