Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeneralPane: Fix settings resetting and improve code #6544

Merged
merged 1 commit into from Mar 28, 2018
Merged

GeneralPane: Fix settings resetting and improve code #6544

merged 1 commit into from Mar 28, 2018

Conversation

spycrab
Copy link
Contributor

@spycrab spycrab commented Mar 27, 2018 •
edited

Fixes issue #10970 for real this time.

leoetlino
leoetlino approved these changes Mar 28, 2018
View reviewed changes
Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please keep the fix and the improvement separate, otherwise it's not obvious what the actual fix is.

@leoetlino leoetlino merged commit 21a2c02 into dolphin-emu:master Mar 28, 2018
@spycrab spycrab deleted the qt_fix_general branch March 28, 2018 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoetlino leoetlino leoetlino approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@spycrab @leoetlino