-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt/GraphicsWindow: Disable unsupported options #6687
Conversation
@@ -98,6 +101,12 @@ void HacksWidget::CreateWidgets() | |||
setLayout(main_layout); | |||
} | |||
|
|||
void HacksWidget::OnBackendChanged() | |||
{ | |||
m_gpu_texture_decoding->setEnabled(g_Config.backend_info.bSupportsGPUTextureDecoding); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
38a1972
to
f29d2d1
Compare
Is it better to disable unsupported options or completely hide them? Right now, WX does the latter but I'm not sure it's the best approach. |
I think disabled is better, honestly. It's kind of disconcerting when options just disappear, not to mention having it disabled gives a nudge to someone cough stenzek cough to implement the feature. :P Also, maybe have some sort of pop up tooltip explaining that it's disabled on this backend? |
f29d2d1
to
f2a9d5a
Compare
Works fine for me. I like it better like this. Popup text takes a while but is consistent with other applications. |
const bool supports_postprocessing = g_Config.backend_info.bSupportsPostProcessing; | ||
m_pp_effect->setEnabled(supports_postprocessing); | ||
|
||
if (!supports_postprocessing) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
f2a9d5a
to
4caca2b
Compare
Fixes issue #11016.