Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt/GraphicsWindow: Disable unsupported options #6687

Merged
merged 1 commit into from
Apr 27, 2018

Conversation

spycrab
Copy link
Contributor

@spycrab spycrab commented Apr 22, 2018

Fixes issue #11016.

@@ -98,6 +101,12 @@ void HacksWidget::CreateWidgets()
setLayout(main_layout);
}

void HacksWidget::OnBackendChanged()
{
m_gpu_texture_decoding->setEnabled(g_Config.backend_info.bSupportsGPUTextureDecoding);

This comment was marked as off-topic.

This comment was marked as off-topic.

@leoetlino
Copy link
Member

Is it better to disable unsupported options or completely hide them? Right now, WX does the latter but I'm not sure it's the best approach.

@MayImilae
Copy link
Contributor

I think disabled is better, honestly. It's kind of disconcerting when options just disappear, not to mention having it disabled gives a nudge to someone cough stenzek cough to implement the feature. :P

Also, maybe have some sort of pop up tooltip explaining that it's disabled on this backend?

@JMC47
Copy link
Contributor

JMC47 commented Apr 24, 2018

Works fine for me. I like it better like this. Popup text takes a while but is consistent with other applications.

const bool supports_postprocessing = g_Config.backend_info.bSupportsPostProcessing;
m_pp_effect->setEnabled(supports_postprocessing);

if (!supports_postprocessing)

This comment was marked as off-topic.

This comment was marked as off-topic.

@leoetlino leoetlino merged commit 9c63bae into dolphin-emu:master Apr 27, 2018
@spycrab spycrab deleted the qt_graphics_caps branch April 27, 2018 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants