Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt/debugger: properly update when we load the symbols on boot #6877

Merged
merged 1 commit into from
May 17, 2018

Conversation

aldelaro5
Copy link
Member

This host event is still useful because the emu thread will load the symbols on boot if required. Though, this is the only useful place where it is used, the rest of the symbols update occurs manually with events when actually loading or editing symbols.

cc: @spycrab

Copy link
Contributor

@spycrab spycrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really drop the habit of emitting signals from outside a class. Signals from the Host class should only be emitted from within that class. Maybe add a Request$SIGNAL function to call it from the outside? Otherwise, LGTM.

@aldelaro5
Copy link
Member Author

Can I know how that would work?

Because I really wonder how you can emit a signal from the instance of the host, but without having to necessarly having to get the instance within that lambda (it didn't seemed like I could do that in the lambda).

@spycrab
Copy link
Contributor

spycrab commented May 17, 2018

@aldelaro5

Something similar to this:

void Host::RequestSomeUpdate()
{
  QueueOnObject(this, [this] { emit SomeUpdate(); });
}
// ...

void Host_SomeThing()
{
  Host::GetInstance().RequestSomeUpdate();
}

@aldelaro5
Copy link
Member Author

@spycrab I tried this and I get the same problem, it doesn't seem you can fire from the instance.

@spycrab
Copy link
Contributor

spycrab commented May 17, 2018

@aldelaro5 Just queue on QApplication::instance() then (for now, atleast).

This host event is still useful because the emu thread will load the symbols on boot if required.
@spycrab spycrab merged commit 72a66d3 into dolphin-emu:master May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants