Fix D3D Real XFB texture sampling. #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
I assume this is meant to address https://code.google.com/p/dolphin-emu/issues/detail?id=6503? The description isn't very clear on this. |
|
@MaJoRoesch Yes, it's exactly this issue. |
|
@dolphin-emu-bot rebuild |
|
Tested and confirmed - this build fixes issue 6503. |
|
Might be related to this bug: https://code.google.com/p/dolphin-emu/issues/detail?id=7193 |
|
@Tilka I don't think so. It may be the same kind of issue, but in other shaders. This PR only touch the d3d real xfb shader, so it won't affect anything which doesn't use real xfb at all. |
|
Could someone test this on AMD? If it doesn't cause any issues, I think this can be merged. |
|
Works fine on my AMD Radeon 5850 |
Sonicadvance1
added a commit
that referenced
this pull request
Aug 2, 2014
Fix D3D Real XFB texture sampling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under the current D3D Real XFB system (which I don't really understand), when the texture lookup takes place, the x-coordinates passed in (x.5) are multiplied by 2, resulting in looking up each pixel about half a pixel too far to the right. This causes graphical errors on NVIDIA hardware due to every fifth column rounding up and choosing the wrong pixel. This fork compensates for incorrect texture coordinates by subtracting one half afterwards.