Android: Return 0 on fail on WiimoteReal IOWrite and update WiimoteNew defaults #7301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w defaults Some of the write checks do an & on the result, returning 0 will allow these fails to be caught. Updated the default WiimoteNew to set wiimotes 2-4 to be disabled on new install. No reason to have these enabled unless there is actually a 2+ players
|
I should mention that the crash by disconnecting mid game was already there, and is not caused by this update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the write checks do an & on the result, returning 0 will allow these fails to be caught.
Updated the default WiimoteNew to set wiimotes 2-4 to be disabled on new install. No reason to have these enabled unless there is actually a 2+ players.
First change fixes a crash at emulation start where a user has two controllers set as Real Wiimotes(source=2) but they only have one Wiimote actually connected to the dolphin bar. There is still a crash if Wiimote 1 is disconnected during gameplay, but this should be less common since it would be an intentional act by the player.
Updating the defaults just cleans some annoyances, one such is being spammed with "Controllers 2-4 Connected" when playing just touch screen.