Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of cheat searching & add input validation #7448

Merged
merged 1 commit into from May 26, 2019
Merged

Improve performance of cheat searching & add input validation #7448

merged 1 commit into from May 26, 2019

Commits on May 26, 2019

  1. CheatsManager: Improve performance of searching & add input validation 

    The previous implementation of cheat search would reconvert the input
string for every single memory value. Now we do it once and construct
a comparison lambda which we pass to the search code.

In addition, I also added input validation. So, for example, if you've
selected Decimal input and you try to compare against "FF",
it won't search and will instead let the user know they've entered an
invalid value. Similar logic for if you enter "1.2" in a search for
bytes. Before, it would just use 0 if it failed to convert the value.
    @RolandMunsil @leoetlino
    RolandMunsil authored and leoetlino committed May 26, 2019
    Copy the full SHA
    4ce7079 View commit details
    Browse the repository at this point in the history