New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glitched corner in Nickelodeon Unite. #7549

Merged
merged 1 commit into from Nov 8, 2018

Conversation

3 participants
@JMC47
Contributor

JMC47 commented Nov 7, 2018

Nicktoon's Unite (also known as Spongebob and Friends Unite) has a black box over the upper left corner of the screen with Store EFB Copies to Texture Only Enabled

gnox78-1

The game also breaks with Defer EFB Copies, so, I've disabled both.

defer

@JMC47

This comment has been minimized.

Contributor

JMC47 commented Nov 7, 2018

@stenzek please review

@stenzek

stenzek approved these changes Nov 8, 2018

Still wondering how the game is synchronizing with the GPU, if at all, but for now this seems fine. Maybe it is just a misbehaving title.

@stenzek stenzek merged commit 80259b0 into dolphin-emu:master Nov 8, 2018

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@mimimi085181

This comment has been minimized.

Contributor

mimimi085181 commented Nov 11, 2018

Is it too early to talk about optimisation of Defer EFB Copies? As i understand it, in single core mode, Dolphin runs the cpu thread for x cycles and then it runs the gpu thread for y commands/cycles/whatever. Shouldn't it be safe to defer the efb copies on single core mode until just before it switches back to the cpu thread? So something like Defer EFB Copies Light for single core only.

Is there any possiblity that this issue is not a wrong read from the cpu, but a change to the graphics object before efb2ram? So the efb copy is created, efb2ram is delayed, the object is changed, and the deferred copy process is made after that change, is that a possibility?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment