Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Add Jit debug options to menu. #7605

Merged
merged 2 commits into from
Jan 7, 2019

Conversation

zackhow
Copy link
Member

@zackhow zackhow commented Dec 3, 2018

QoL for testing so users won't have to compile a custom build when testing Jit crashes.

@JMC47 just for you
debug1
debug2

@delroth
Copy link
Member

delroth commented Dec 4, 2018

Maybe we should have a "Developer options" menu that shows up with a hidden combo... (akin to what the Android settings app does).

(But this is just fine for now.)

@JMC47
Copy link
Contributor

JMC47 commented Dec 21, 2018

There appears to be a typo (or I'm just dumb) but Jit Load Store Disabled says "Jitm Load Store Disabled"

@JMC47
Copy link
Contributor

JMC47 commented Dec 21, 2018

There's a really frustrating bug where it'll enable all checkboxes if you check Jit Integer and then leave the menu.

@zackhow
Copy link
Member Author

zackhow commented Dec 21, 2018

There's a really frustrating bug where it'll enable all checkboxes if you check Jit Integer and then leave the menu.

Fixed.

Maybe we should have a "Developer options" menu that shows up with a hidden combo... (akin to what the Android settings app does).

I'll have some time in the next couple of days to look at doing something like this but if I haven't pushed something by EOM then I can do it in another PR. My only reservation is it can't be too difficult to figure out otherwise users will have issues just trying to open this menu. Probably need to start a wiki page for "Android Debugging" that includes guides to setting up ADB, modifying dolphin config(log) files, and pulling logs. I also may go and finish #7252 so that users can set log levels in the app.

@JMC47
Copy link
Contributor

JMC47 commented Jan 2, 2019

If this is fine for now I'm good with it being merged with the fixes. Allows our users to get in on the debuggin action.

@JMC47 JMC47 added the QA done The PR has been checked to work properly. label Jan 2, 2019
@Helios747 Helios747 merged commit 3da0697 into dolphin-emu:master Jan 7, 2019
@zackhow zackhow deleted the jitarmconfigs branch January 10, 2019 03:23
@wirasablenk

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA done The PR has been checked to work properly.
5 participants