DirectInput: Use more than 8 bits of precision on axis inputs. #7680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any need for value clamping (or scaling) when doing this? |
|
@BhaaLseN No. The code inside the Axis class already normalizes between 0.0 and 1.0. |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DirectInput will now try to use 16 bit precision on axis inputs.
While the gamecube controller sticks we emulate are only 8 bit, things like Wiimote tilt and IR cursor inputs have more precision.
Plus we are applying dead zones and all sorts of math before chopping it down to 8 bits so we might as well grab more if it's available.