New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DirectInput: Use more than 8 bits of precision on axis inputs. #7680

Merged
merged 1 commit into from Jan 16, 2019

Conversation

4 participants
@jordan-woyak
Copy link
Contributor

jordan-woyak commented Jan 6, 2019

DirectInput will now try to use 16 bit precision on axis inputs.
While the gamecube controller sticks we emulate are only 8 bit, things like Wiimote tilt and IR cursor inputs have more precision.
Plus we are applying dead zones and all sorts of math before chopping it down to 8 bits so we might as well grab more if it's available.

@BhaaLseN

This comment has been minimized.

Copy link
Member

BhaaLseN commented Jan 6, 2019

Is there any need for value clamping (or scaling) when doing this?

@jordan-woyak

This comment has been minimized.

Copy link
Contributor

jordan-woyak commented Jan 6, 2019

@BhaaLseN No. The code inside the Axis class already normalizes between 0.0 and 1.0.
This just tries to set a more sensible range to get from direct input.

@Zexaron

This comment was marked as off-topic.

Copy link
Contributor

Zexaron commented Jan 6, 2019

It might be of some value if it works like super-resolution and such, when you downsize from a higher quality source. If that had no value then it wouldn't be an official feature in the GPU vendor driver utilities, for example.

@leoetlino leoetlino merged commit b2de98c into dolphin-emu:master Jan 16, 2019

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment