HW: SI_Device_GCAdapter: Restore calibration behavior for real gamecube controllers.

[jordan-woyak]

Calibrating to perfect neutral (PR #7728) is causing issues with real gamecube controllers.

Restore the old calibration behavior for GCAdapter and calibrate to perfect neutral only for fully emulated controllers.

I've unfortunately had to put some duplicate logic in GCController and GCAdapter because of how unorganized our netplay code is.

[BhaaLseN]

Looks like it could be working, untested tho (mostly since I don't have a GC Adapter nor GC Controller at hand at this point)

[JMC47]

My wavebird is in fairly good condition so I didn't get the issue described by the user in the other Pull Request. The R/L in master is so sensitive that simply shaking the controller hard enough will cause light shielding from the R/L buttons shifting, where as with this calibration you actually have to push the button a bit.

This behavior is more like console where shaking the controller is not enough to cause light shielding. Shaking is for Wii games.

[K8SRGL]

My wavebird is in fairly good condition so I didn't get the issue described by the user in the other Pull Request. The R/L in master is so sensitive that simply shaking the controller hard enough will cause light shielding from the R/L buttons shifting, where as with this calibration you actually have to push the button a bit.

This behavior is more like console where shaking the controller is not enough to cause light shielding. Shaking is for Wii games.

Even though they're in really good shape, I've had these controllers since I was young (around the launch of the GameCube to be exact!) and many hours of Smash have been played using them, so that might have been part of it. :P Glad to see this get pushed through so others won't have to spend over an hour trying to figure out what suddenly broke with their controllers, only to find out it wasn't the controller at all! 👍

[JMC47]

Yep, it was too sensitive before, so, definitely didn't want to have it as broken for people with controllers that have had more use. Needed this merged before the progress report so there wasn't a huge regression in Smash that everyone would hate us over :)