-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FFV1 fix #7874
FFV1 fix #7874
Conversation
Could you please rebase this on the latest master? Looks like our FifoCI buildbots are failing to build because it's missing the ICE fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The alpha channel should be set to 1 anyway for all frames, so I can't see this hurting anything.
FifoCI says it's fine (FFV1 is used for frame dumping there IIRC).
You'll need to rebase the branch so that there isn't a merge commit in it. |
@JosJuice will it remain there if the PR is squashed? I don't know what went wrong on my end. Commits got duplicated for whatever reason as well, so I wonder if squashing helps, since the diff is just 2 numbers. |
It will not remain in there if you do it properly. They likely got duplicated because you pulled from your own remote before pushing. You can try one of the following:
Once this is done and your history looks ok, you want |
for this kind of footage carrying alpha information makes no sense, and it additionally complicates things by hugely damaging compatibility of the resulting video. after this change alone the video becomes compatible with VfW/WinAPI and tools that rely on it (avisynth, virtualdub). fixes https://bugs.dolphin-emu.org/issues/11141 and https://bugs.dolphin-emu.org/issues/10193
this makes seeking a lot smoother (especially at high resolutions), while only adding less than 1% of filesize with this codec.
Is it okay now? One of the builds failed, but the reason doesn't seem to be relevant. |
Yeah, it looks fine. The macOS buildbot is just broken in general right now. @RisingFog, do you want to take a look at this PR? |
Looks good to me. |
Change pixel format from BGRA to BGR0
For this kind of footage carrying alpha information makes no sense, and it additionally complicates things by hugely damaging compatibility of the resulting video. After this change alone the video becomes compatible with VfW/WinAPI and tools that rely on it (avisynth, virtualdub).
Fixes https://bugs.dolphin-emu.org/issues/11141 and https://bugs.dolphin-emu.org/issues/10193
Note that internally pixel format seems to be RGBA or BGR24, but then it's converted to whatever is set for ffmpeg, and I'm only changing the latter.
Decrease gop size (keyint)
This makes seeking a lot smoother (especially at high resolutions), while only adding less than 1% of filesize overhead with this codec.