Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Comments Needed] Core: Pause CPU and other systems only if initialized fully #8335

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Comments Needed] Core: Pause CPU and other systems only if initialized fully #8335

wants to merge 2 commits into from

Commits on Apr 6, 2021

  1. Core: Turn stopping/started/HW initialized booleans into atomic flags 

    Those flags are written to and read from concurrently,
and reading/writing to the same non-atomic variable is UB
    @CookiePLMonster
    CookiePLMonster committed Apr 6, 2021
    Copy the full SHA
    4b5d4c8 View commit details
    Browse the repository at this point in the history

  2. Core: Pause CPU and other systems only if they have initialized fully 

    Fixes a race condition where invoking RunAsCPUThread before Emulation thread has fully started,
resulting in Dolphin attempting to pause yet uninitialized systems
    @CookiePLMonster
    CookiePLMonster committed Apr 6, 2021
    Copy the full SHA
    44916cb View commit details
    Browse the repository at this point in the history