HLE: Fix patching functions with the same name #8370
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address the following issue: https://bugs.dolphin-emu.org/issues/11811
When multiple functions with the same name were patched, only the first one (earliest memory address) was properly patched.
Here is an example: unittest_hle_printf.zip
The expected behaviour with this PR is to print twice each message after loading the symbol map. One from the
my_puts_*
functions renamed asprintf
and the originalprintf
function itself. The "Boot to Pause" option might be used to clear the ELF symbol and loading the symbol map before running the executable.Ready to be reviewed & merged.