Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLE: Fix patching functions with the same name #8370

Merged
merged 1 commit into from Oct 6, 2019

Conversation

@sepalani
Copy link
Contributor

commented Sep 28, 2019

This PR address the following issue: https://bugs.dolphin-emu.org/issues/11811

When multiple functions with the same name were patched, only the first one (earliest memory address) was properly patched.

Here is an example: unittest_hle_printf.zip

The expected behaviour with this PR is to print twice each message after loading the symbol map. One from the my_puts_* functions renamed as printf and the original printf function itself. The "Boot to Pause" option might be used to clear the ELF symbol and loading the symbol map before running the executable.

Ready to be reviewed & merged.

@JMC47 JMC47 merged commit b6545ea into dolphin-emu:master Oct 6, 2019
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.