Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Make builds more reproducible #8411

Merged
merged 1 commit into from Oct 20, 2019
Merged

Conversation

spycrab
Copy link
Contributor

@spycrab spycrab commented Oct 18, 2019

Hopefully helps us with whitelisting our updater...

@BhaaLseN
Copy link
Member

Somewhat sad that this has to be an undocumented flag. At least in Roslyn, theres the documented /deterministic switch and the project option <Deterministic>true</Deterministic>.
But it could be worth a try. +1 from my side unless someone specifically disagrees (or has a good reason to not do this).

@spycrab
Copy link
Contributor Author

spycrab commented Oct 18, 2019

I'm not quite sure yet if this actually helped any. It looks to me as if at least one timestamp remains. Has to be looked into further

@BhaaLseN
Copy link
Member

I did a few builds/rebuilds and came out with the same md5sum; even though switched commits between them. So I guess...it kinda works?

@spycrab
Copy link
Contributor Author

spycrab commented Oct 18, 2019

Well it might be at least better than nothing.

@spycrab spycrab merged commit da22109 into dolphin-emu:master Oct 20, 2019
@spycrab spycrab deleted the win_repro branch October 20, 2019 11:15
@mbc07
Copy link
Contributor

mbc07 commented Oct 21, 2019

Doesn't seem to work, updater binary still get different hashes after this PR. At least I successfully downloaded 5.0-11044, 5.0-11046 and 5.0-11048 without triggering false positive alerts on Windows Defender, but unsure if the problem was really fixed or if it's just that somebody else already submitted those binaries for analysis...

@BhaaLseN
Copy link
Member

We don't bake the sha1 in like we do with the main executable, do we? I'm not quite sure why this happens tho...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants