[WIP] HW/DSPHLE: Refactor Old AX Wii into a separate class #8529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Old AX Wii games having no audio when compiled under VS2019. This also includes some minor code cleanup and moving a function to avoid duplication.
Techjar
force-pushed
the
axwii-refactor
branch
from
a1cf193
to
40b6c93
Compare
|
What's the status of this PR, now that #8525 is merged? |
BhaaLseN
reviewed
Mar 16, 2020
| @@ -113,6 +113,14 @@ struct PBUpdates | |||
| u16 data_lo; | |||
| }; | |||
|
|
|||
| // Old AX Wii uses update data, but a block is 3ms. | |||
There was a problem hiding this comment.
It's been a while that I worked on the DSP, but this comment doesn't really make sense to me in its current form?
There was a problem hiding this comment.
It's not really clear to me either what update data is. If someone could provide a better explanation I'd be happy to put it in the comment.
| { | ||
| volume = m_cmdlist[curr_idx++]; | ||
| u32 addresses[6] = { | ||
| (u32)(m_cmdlist[curr_idx + 0] << 16) | m_cmdlist[curr_idx + 1], |
There was a problem hiding this comment.
I wonder if we should clean those up into proper casts while we're at it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #8525