Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the evdev "interesting" heuristic #8553

Merged
merged 2 commits into from Jan 7, 2020
Merged

Conversation

phire
Copy link
Member

@phire phire commented Jan 6, 2020

Was checking over this old code, and saw a comment calling me out for a lack of documentation.

It might be half a decade late, but better late then never.

Was checking over this old code, and saw a comment calling me out for a lack of documentation.

It might be half a decade late, but better late then never.
@i30817
Copy link

i30817 commented Jan 7, 2020

Unfortunate these libraries don't have a tag mechanism. What's even the point of knowing how many axis something has if you can't tell it's a classic controller or a joystick or a mousewheel or a touchpad? (ppsspp detects my touchpad as a 'controller stick' and i'm bitter it also controls the UI, so i can't use non-libretro ppsspp on linux because moving the touchpad right to left in the ui cancels the submenu).

@phire
Copy link
Member Author

phire commented Jan 7, 2020

Not really an issue for dolphin, as dolphin doesn't automatically configure a controller. interesting just means it shows up in the list of potential controllers a user might want to set up.

The alternative is having only a narrow number of controllers white-listed by layout, like xinput does on windows. "Does it look like an xbox350 controller? No, then we don't support it". By doing it this way, we get to support any controller some random manufacture might put out in the future.

@phire phire merged commit 54fd83d into master Jan 7, 2020
@phire phire deleted the document-evdev-heuristic branch January 7, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants