InputCommon: Use the Window handle when initializing DirectInput. #8795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dolphin-emu-bot rebuild |
stenzek
reviewed
May 9, 2020
There was a problem hiding this comment.
Thanks for bisecting/debugging! This should apply to the other platforms too, the only place the surface is different to the window is macos, and the surface points to the layer there (so the window should be used, not the surface/layer). So lines 113, 118, 119 (all platforms) should also be m_wsi.render_window. Not sure how I missed this...
|
Should be all done 👍 |
|
This seems to have fixed a bug where about 1 times out of 4 the game windows would not receive any input (mouse/keyboard). |
|
Guess what? This broke MoltenVK on macOS... again... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when initializing the Win32 input layer (and as a result DirectInput), Dolphin would use the handle of the render widget, which isn't updated when
ControllerInterface::ChangeWindowis called. This had the annoying side effect of making all mouse input to Dolphin on Windows relative to the main Dolphin window, not the actual render target or render window.This PR makes sure the Win32 controller interface is initialized using the actual window handle, which in turn makes mouse input relative to the render target itself, not the main window.