Wii TAS input: fix offset in IR coordinates

[Felk]

The TAS input currently has some weird placement for its made-up IR lights. This causes an offset while the TAS UI suggests the cursor should be perfectly centered.

Here are before and after screenshots for visualization:

Also: Do you think adding a fixed offset to the y-coordinate is ok? This will probably make the offset worse for people who changed their sensor bar's position settings to "below screen", but I don't know if people even do that.

[jordan-woyak]

Couldn't this be fixed properly by using the same routine that the emulated remote's CameraLogic class uses?

[JosJuice]

The current value of the sensor bar position setting should ideally be taken into account for the y coordinate. This is how it's currently handled by the regular IR code:

dolphin/Source/Core/Core/HW/WiimoteEmu/Dynamics.cpp

Line 236 in 75e79ec

const bool sensor_bar_on_top = Config::Get(Config::SYSCONF_SENSOR_BAR_POSITION) != 0;

However, I'm not sure if that approach works correctly in the case where the value of the setting in the temporary TASing NAND differs from the value of the setting in the normal NAND. Since the SYSCONF in the temporary NAND has most values set to the default, it may be better to not take the setting into account than to use an approach which takes the wrong setting into account.

[Felk]

Couldn't this be fixed properly by using the same routine that the emulated remote's CameraLogic class uses?

Looks like it could, Ideally by just extracting the conversion from Matrix44 to bytes to some InputCommon utility I suppose?

[Felk]

If I change the code to use an emulated position of the wiimote, having the TAS window go from 0-1024 for x and 0-768 for y doesn't make much sense anymore. Here's what I came up with instead:

That's now just arbitrarily goes from -100 to 100 in x and from -75 to 75 in y, which is the wiimote position's offset in centimeters. The additional slider below that is currently set to 500 is the distance from the IR sensor LEDs in centimeters (5 meters by default), and arbitrarily goes from 50 to 10000 (10 meters). I did not apply any offset in y-direction this time, so setting x and y to 0 causes the in-game cursor to be slighly above the center again.

Would this be acceptable?

[jordan-woyak]

@Felk
The "x" and "y" should probably apply rotations instead of centimeter offsets.
I would make the default distance the same as that of the emulated remote (2 meters).

[Felk]

With x and y being rotation in arc minutes:

[MoskovchenkoD]

Thank you for posting this issue. I have the same trouble with Resident Evil 4 for Wii which sometimes goes out of sync on specific IRs. In my case, 1x and 2x works fine, but 3x desyncs.

Game ID: RB4E08.wbfs
Here is a test movie: RE4-part4.zip
Here is a memory card to use (already placed in the data folder): Dolphin Emulator.zip
Here is a video which shows a desync: video

[Felk]

Thank you for posting this issue. I have the same trouble with Resident Evil 4 for Wii which sometimes goes out of sync on specific IRs. 1x and 2x works fine, but 3x desyncs.

I don't think that this merge request will affect any TAS desyncing issues, as it's basically just a code refactor and gui change

[JMC47]

changing IR to games that read the framebuffer is expected to cause desyncs.