Evict registers from the cache based on LRU. #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comex
force-pushed
the
eviction-policy
branch
from
f42945f
to
5704669
Compare
|
update: fixed |
| @@ -45,6 +46,8 @@ class RegCache | |||
|
|
|||
| Gen::XEmitter *emit; | |||
|
|
|||
| u32 cur_use_quantum; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
This looks like an improvement. @JMC47 This could potentially have a performance boost on some games, could we get some benchmarks? |
The old method would always evict the first suitable register, i.e. the same register every time once the cache got full. The cache doesn't get terribly often, but the result is pathological...
comex
force-pushed
the
eviction-policy
branch
from
5704669
to
f5c7f67
Compare
|
Looks good to me. |
comex
added a commit
that referenced
this pull request
Sep 3, 2014
Evict registers from the cache based on LRU.
|
@comex We should also try to flushread_only cached registers first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old method would always evict the first suitable register, i.e. the
same register every time once the cache got full. The cache doesn't get
full terribly often, but the result is pathological...