Remove "EFB Copies Disabled" option from hotkey toggling cycle.

[TurboK234]

I would imagine "EFB Copies" hotkey is 99% of the time used to toggle between EFB2RAM and EFM2Texture by users that have less-than-optimal Dolphin hardware and can't use EFB2RAM all the time in games that require it (often only for short periods). So the toggling workflow could be streamlined if there wasn't "EFB Copies = Disabled" option in the cycle.

This commit removes the "Disable EFB Copies" option from the hotkey toggling behaviour. It can still be chosen from the GUI if someone enjoys looking at broken graphics. And if Disabled is chosen, the hotkey won't have apparent effect.

And please correct me (and close the PR) if I'm totally off with the initial assumption of the need for the hotkey.

[degasus]

@dolphin-emu-bot rebuild

I'm +1 for this change, so LGTM

[phire]

And if Disabled is chosen, the hotkey won't have apparent effect.

I'm not sure if this is desired behaviour or not. It might be a better idea to have pressing the toggle key enable EFB copies if it is pressed, or at the very least display an OSD message saying "Please enable EFB Copies in the graphics options" so the user has an idea why the button isn't doing anything.

[TurboK234]

I can add some lines so that EFB copies will get enabled if they initially were disabled, and only after enabling EFB copies would they cycle between EFB2RAM and EFB2Tex. How does that sound?

[comex]

That sounds potentially slightly confusing.

[TurboK234]

I would also think that removing the Disabled from the hotkey binding is clearer. Are there any titles that would benefit from having EFB copies disabled? So that user (or gameini) might end up selecting "disabled" in the first place (and then end up wondering why the he/she can't toggle)?
But I can try to add a OSD message that states "EFB Copies disabled, please enable them" or something.

[comex]

I'd go for that. shrug

[phire]

Yeah, the message would probably be best.

[TurboK234]

Ok done, please instruct if I somehow need to merge these commits to one commit in git.

[skidau]

@dolphin-emu-bot rebuild

[MayImilae]

+1 for this change. No one should be disabling EFB Copies so freely. Besides, it's pretty useless. In every experience I've had with the EFB toggle, the disabled step just means more button presses.

[degasus]

still LGTM