Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoBackendBase: Prefer Vulkan over OGL on macOS Mojave and newer #9962

Merged
merged 1 commit into from Aug 2, 2021

Conversation

OatmealDome
Copy link
Member

macOS's OpenGL support is terribly outdated - it's been stuck on OpenGL 4.1 since Mavericks (released in 2013!) and doesn't support key extensions like ARB_buffer_storage. Plus, starting with macOS Mojave, OpenGL has been deprecated and may be removed in a future macOS.

Now that we have MoltenVK, it might be best to set the Vulkan backend as default for new users with Macs that run Mojave and newer. (High Sierra and older don't support some Metal features that Dolphin requires.)

@OatmealDome OatmealDome marked this pull request as ready for review July 25, 2021 20:54
@ghost
Copy link

ghost commented Jul 25, 2021

Can you also do this on android?
I prefer vulkan over opengl in terms of performance and battery life of my phone.

@JMC47
Copy link
Contributor

JMC47 commented Jul 25, 2021

For most android users, Vulkan performs worse so no.

@OatmealDome OatmealDome changed the title [RFC] VideoBackendBase: Prefer Vulkan over OGL on macOS Mojave and newer VideoBackendBase: Prefer Vulkan over OGL on macOS Mojave and newer Jul 25, 2021
@ghost
Copy link

ghost commented Jul 25, 2021

For most android users, Vulkan performs worse so no.

Ah ok :)
But maybe someday when vulkan is optimize on android...

@nickp-ca
Copy link

nickp-ca commented Jul 31, 2021

For MacOS, what is criteria for pulling recent Khronos maintained source for MoltenVK, this is now showing 2 months stale with the libvulkan.dylib in Dolphin - a few key areas have been corrected specific to apple silicon use - https://github.com/KhronosGroup/MoltenVK is shadowing 1.2.182 of Vulkan whereas Dolphin is still at 1.2.170.0. Since this is a work in progress from contributors to that program and issues are being addressed, is there a better methodology to rebuild the dynamic library on a more regular cadence?

@OatmealDome
Copy link
Member Author

@nickp-ca

As far as I'm aware, there is no specific criteria. The last update happened because the older MoltenVK version was not compatible with Apple Silicon.

I hope to submit a PR soon which will remove the precompiled binary and integrate MoltenVK with Dolphin's CMake build system as an external project. This should make it easier to update in the future.

Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On macOS this seems like a no brainer considering how badly supported OpenGL is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants