Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at merges doc #661

Merged
merged 9 commits into from
Jun 13, 2022
Merged

First pass at merges doc #661

merged 9 commits into from
Jun 13, 2022

Conversation

timsehn
Copy link
Sponsor Contributor

@timsehn timsehn commented Jun 13, 2022

Fixes #632

@timsehn timsehn requested a review from druvv June 13, 2022 22:33
Copy link
Contributor

@druvv druvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, what do you want to do about constraint violations?

content/reference/sql/version-control/merges.md Outdated Show resolved Hide resolved
set @@dolt_allow_commit_conflicts = 1;
```

The server will not allow you to create new Dolt commits (with the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something that may be important to clarify is that the moment you sql transaction commit, commit conflicts into a working set, any other MySQL client has to set @@dolt_allow_commit_conflicts = 1 even if they aren't producing new conflicts.

Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if they don't?

Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to add this note yourself.

@timsehn timsehn merged commit b5526e1 into gitbook-dev Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Doc: SQL Reference/Version Control Features/Merge
2 participants