Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload units do not properly update #3149

Closed
CaptainStabs opened this issue Apr 4, 2022 · 5 comments · Fixed by #4334
Closed

Upload units do not properly update #3149

CaptainStabs opened this issue Apr 4, 2022 · 5 comments · Fixed by #4334
Assignees
@druvv
Labels
bug Something isn't working cli windows For Windows specific bugs

Comments

@CaptainStabs
Copy link

image
@fulghum fulghum mentioned this issue Apr 14, 2022
Closed
@fulghum fulghum added the bug Something isn't working label Apr 14, 2022
@fulghum
Copy link
Contributor

fulghum commented Apr 14, 2022

@druvv – could you take a look at this one? It looks like this is reporting that the upload speed units is showing both kB/s and also B/s.

@druvv
Copy link
Contributor

druvv commented Apr 18, 2022

It seems like this occurs when the newly written line is shorter than the last written line. The newly written line is flushed and overwrites the old line, but doesn't overwrite any text after the old line.

@timsehn timsehn closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2022
@timsehn
Copy link
Sponsor Contributor

timsehn commented Sep 2, 2022

I just saw this on the CLI. @druvv is going to fix.

@timsehn timsehn reopened this Sep 2, 2022
@timsehn timsehn added the cli label Sep 2, 2022
@druvv druvv mentioned this issue Sep 13, 2022
Merged
@timsehn
Copy link
Sponsor Contributor

timsehn commented Oct 5, 2022

This still happens on Windows cmd.

@timsehn timsehn reopened this Oct 5, 2022
@timsehn timsehn added the windows For Windows specific bugs label Oct 5, 2022
@timsehn
Copy link
Sponsor Contributor

timsehn commented Oct 5, 2022

This was actually a really small number bug fixed here: #4467

@timsehn timsehn closed this as completed Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@druvv druvv

Labels
bug Something isn't working cli windows For Windows specific bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes progress reporting bugginess dolthub/dolt
4 participants
@fulghum @timsehn @druvv @CaptainStabs