Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/datas/pull: If the BPS is less than 1, report 0 #4467

Merged
merged 1 commit into from Oct 5, 2022
Merged

store/datas/pull: If the BPS is less than 1, report 0 #4467

merged 1 commit into from Oct 5, 2022

Conversation

druvv
Copy link
Contributor

@druvv druvv commented Oct 5, 2022

image
^ prevents the push / pull progress reporter from reporting very small BP/s units.

@druvv druvv requested a review from reltuk October 5, 2022 20:16
timsehn
timsehn approved these changes Oct 5, 2022
View reviewed changes
Copy link
Sponsor Contributor

@timsehn timsehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timsehn timsehn mentioned this pull request Oct 5, 2022
Closed
@druvv druvv merged commit 6971334 into main Oct 5, 2022
@Hydrocharged Hydrocharged deleted the dhruv/round-pull-push-speed branch October 13, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timsehn timsehn timsehn approved these changes

@reltuk reltuk Awaiting requested review from reltuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@druvv @timsehn