Dolt upgrade seems to have lost some settings

[n0mn0m]

Upgrade from dolt 0.40.5 to 0.40.19 last night seems to have created a couple interesting side effects.

Default branch per database settings where lost. We set the default branch using:

SET PERSIST <db>_default_branch='dev'

Based on the docs I thought this would survive a restart/upgrade, but this morning the variable appeared unset and connections were operating against main by default.

Additionally we have a role setup with SELECT and EXECUTE:

CREATE ROLE foo_role;
GRANT SELECT, EXECUTE on *.* TO foo_role;
FLUSH PRIVILEGES;
GRANT foo_role TO <user>@'%';
FLUSH PRIVILEGES;

Previously users could run SELECT and CALL statements/procedures. Today users were receiving the error [HY000][1105] command denied to user .

[druvv]

Thanks for cutting the issue @n0mn0m, we'll investigate today and provide an update.

[druvv]

Just noticed that there are two bugs here. Just made #3890 to track the second bug about the privileges being dropped.

[druvv]

Hey @n0mn0m, setting that variable in Dolt versions 0.40.5 and 0.40.19 does not persist after restarting the sql-server. On restart, the following error is thrown:

error: failed to load persisted global variables: key: 'repro_default_branch'; Unknown system variable 'repro_default_branch'
Starting server with Config HP="localhost:3306"|T="28800000"|R="false"|L="info"

So you definitely we're using the right commands, the functionality is broken for default_branch. We'll make a fix for this tomorrow.

[druvv]

Getting started on this now