Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for persisted database specific system variables failing to load #3905

Merged
merged 5 commits into from Jul 25, 2022
Merged

Fix for persisted database specific system variables failing to load #3905

merged 5 commits into from Jul 25, 2022

Conversation

druvv
Copy link
Contributor

@druvv druvv commented Jul 22, 2022

Fix for #3887

Persisting and loading ${branch_name}_default_branch from config now works.

@druvv druvv requested a review from max-hoffman July 22, 2022 22:30
max-hoffman
max-hoffman approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, two comments are 1) NewSqlEngine might be the place to lazily load these values, and 2) if you can log without the callback it'd be cleaner

@druvv druvv merged commit 47f2f32 into main Jul 25, 2022
@Hydrocharged Hydrocharged deleted the dhruv/default-branch-bug branch October 13, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@druvv @max-hoffman