Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DATEDIFF #7276

Closed
timsehn opened this issue Jan 9, 2024 · 1 comment
Closed

Implement DATEDIFF #7276

timsehn opened this issue Jan 9, 2024 · 1 comment
Assignees
Labels
correctness We don't return the same result as MySQL customer issue enhancement New feature or request

Comments

@timsehn
Copy link
Sponsor Contributor

timsehn commented Jan 9, 2024

From this Reddit thread. Potential customer ask:

https://www.reddit.com/r/PHP/comments/191yakg/comment/kh103cz/?context=3

https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_datediff

@timsehn timsehn added customer issue enhancement New feature or request correctness We don't return the same result as MySQL labels Jan 9, 2024
@fulghum fulghum self-assigned this Jan 10, 2024
@fulghum
Copy link
Contributor

fulghum commented Jan 10, 2024

Looks like datediff was already implemented, but our docs were out of date:

jan10/main> select dolt_version();
+----------------+
| dolt_version() |
+----------------+
| 1.31.0         |
+----------------+

jan10/main> select datediff('2007-12-31 23:59:59','2007-12-30');
+----------------------------------------------+
| datediff('2007-12-31 23:59:59','2007-12-30') |
+----------------------------------------------+
| 1                                            |
+----------------------------------------------+

I'll update our docs and fix the out of date info as part of #7277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correctness We don't return the same result as MySQL customer issue enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants