Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
dolt table import --all-text
correctly infers pk if none givendolt table import
will use the first column in the import file as the primary key if none is explicitly defined. This change updates--all-text
to also correctly do this inference.dolt table import
Adds the
--all-text
option todolt table import
which will default all columns toTEXT
type.Resolves: feature request: dolt table import add option to default to text/varchar type dolthub/dolt#6471
go-mysql-server
This hopefully fixes 24 sqllogictests.
We introduced an optimization where we would drop
Sort
nodes for queries that includedORDER BY
s if there wereIndexLookup
s that were a matching prefix over the sortfields. The idea was that since indexes are already in order there was no need to sort.However, there is a case when that isn't necessarily true. If the index is created from a filter over multiple columns, specifically when that filter contains an
OR
expression, it is possible to iterate over columns in a non-sorted order. During analysis, the filters are converted into several non-overlapping ranges; it is possible for a range expression in the range to overlap with another range's range expression, but for the two ranges to not overlap. It's clearer to look at the test.We didn't catch this bug earlier, as it only affects queries in dolt. We iterate over rows in the in-memory tables in such a way that the rows will still appear in order.
We are failing 42 sqllogictest with the same error:
Out of bounds value for decimal type
.This is caused by Case performing a
convert
to a decimal type that had a badexclusiveUpperBound
.MySQL has specific rules about the precision , scale, and conversion of decimals, and it is difficult to match their behavior exactly.
Fortunately, the result is correct before the conversion, so the fix here is to just use the result, and not convert.
This is somewhat of a bandaid fix; decimal type is an area that needs more improvement in general.
Fixes Error in evaluating expression: "Out of range value for column of Decimal type" dolthub/dolt#7079
fixes Unexpected Result when Querying with
CONCAT
dolthub/dolt#7261SYSDATE()
functionAdds support for the
SYSDATE()
function.Related to: Please implement SYSDATE for Mediawiki install dolthub/dolt#7270
See Define an ExtendedHandler interface to handle postgres specific interactions dolthub/vitess#299 for new handler interface
This includes three main changes:
I'm most interested in feedback on 3) before I go deeper on it. It's implemented only for insert values and comparison expressions (used in filters). A complete solution also requires support for UPDATE and probably some other expression types. If this approach is too hacky or is likely to break or interfere with other things, I want to know before continuing. If the latter, it would be pretty easy to introduce a bind context specific to this use case and not assign types unless it's set.
See Prepared statement support dolthub/doltgresql#87 for how doltgres uses this new bindvar type information.
vitess
These are pretty narrowly tailored for postgres prepared statements and long term should probably be placed in either doltgresql or another package. Defining them here is just expedient for experimenting with the new interfaces while they change.
14 SQL correctness tests are failing because we throw syntax errors on queries like this:
Closed Issues
CONCAT