go/{store,libraries/doltcore/remotestorage}: Make the code peddling in nbs table file formats a little more explicit about it. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n nbs table file formats a little more explicit about it.
reltuk
commented
Oct 1, 2019
reltuk
commented
Oct 1, 2019
reltuk
commented
Oct 1, 2019
reltuk
commented
Oct 1, 2019
added 6 commits
October 1, 2019 15:20
…-no-getmanycompressed
…mpressedChunk bug.
reltuk
commented
Oct 2, 2019
reltuk
commented
Oct 2, 2019
bheni
approved these changes
Oct 2, 2019
go/store/types/indexed_sequences.go
Outdated
| @@ -200,7 +200,7 @@ func LoadLeafNodes(ctx context.Context, cols []Collection, startIdx, endIdx uint | |||
| var ok bool | |||
| childCols[i], ok = v.(Collection) | |||
| if !ok { | |||
| return nil, 0, errors.New("corrupted database; nil where child collection .(Collection) should be") | |||
| return nil, 0, fmt.Errorf("corrupted database; nil where child collection .(Collection) should be; i: %v, h: %v", i, hs[i]) | |||
There was a problem hiding this comment.
maybe add
; indexed_sequence;
to here to be consistent from the meta_sequence error.
added 5 commits
October 2, 2019 11:37
…m init() to unit tests.
…ManyCompressed in NewPuller.
… database GetManyValues missing result log line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.