Add dolt_commit error check when autocommit is off #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinaiRachakonda
changed the title
zachmu
reviewed
Dec 4, 2020
There was a problem hiding this comment.
Not quite the right way to solve this.
It's OK for the error message to mention @@autocommit, but the business logic shouldn't depend on that detail.
zachmu
approved these changes
Dec 12, 2020
| [[ "$output" =~ "one_pk" ]] || false | ||
|
|
||
| # check that dolt_commit works properly when autocommit is on | ||
| run dolt sql -q "SELECT DOLT_COMMIT('-a', '-m', 'Commit1')" |
There was a problem hiding this comment.
Also should have a test of the negative case, where there are no staged changes / no changes to stage. With and without -a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fails loudly when autocommit is off for dolt_commit.