Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed shell error loop on UNIQUE violation #1080

Merged
merged 2 commits into from Dec 8, 2020
Merged

Fixed shell error loop on UNIQUE violation #1080

merged 2 commits into from Dec 8, 2020

Conversation

Hydrocharged
Copy link
Contributor

Fixes #1079

zachmu
zachmu reviewed Dec 8, 2020
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This... seems fine? A test of this behavior would be better

@Hydrocharged
Copy link
Contributor Author

How do we test the interactive shell? I wasn't too sure so I didn't include it.

@Hydrocharged
Copy link
Contributor Author

Added a go test. Doesn't test the exact issue, but stems from the same root cause.

zachmu
zachmu approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hydrocharged Hydrocharged merged commit 8a2a94c into master Dec 8, 2020
@Hydrocharged Hydrocharged deleted the daylon/unique-error branch December 8, 2020 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indefinitely errors in SQL shell once a UNIQUE constraint has been violated
2 participants
@Hydrocharged @zachmu