Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed internal index comparisons considering unnecessary parameters #1082

Merged
merged 2 commits into from Dec 8, 2020
Merged

Fixed internal index comparisons considering unnecessary parameters #1082

merged 2 commits into from Dec 8, 2020

Conversation

Hydrocharged
Copy link
Contributor

Fixes #1081

zachmu
zachmu approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is a bit o_0 otherwise LG

bats/regression-tests.bats Show resolved Hide resolved
go/libraries/doltcore/sqle/dolt_index.go Outdated Show resolved Hide resolved
@Hydrocharged Hydrocharged merged commit 4c449df into master Dec 8, 2020
@Hydrocharged Hydrocharged deleted the daylon/str-too-long branch December 8, 2020 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"string is too large for column"
2 participants
@Hydrocharged @zachmu