Add --author, -m to COMMIT. Add --author to MERGE() #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinaiRachakonda
changed the title
VinaiRachakonda
changed the title
zachmu
approved these changes
Dec 12, 2020
| if sess.Username == "" || sess.Email == "" { | ||
| return nil, errors.New("commit function failure: Username and/or email not configured") | ||
|
|
||
| // Get the params associated with MERGE. We can share the commit argparser for now. |
There was a problem hiding this comment.
I think it's because the Merge in commands.go and the Merge in dfunctions.go support different arguments. This could trip up the HelpAndUsagePrinters function.
I am going to leave this as a TODO for now, and do some refactoring in a future PR.
| } | ||
|
|
||
| // Eval implements the Expression interface. | ||
| func (cf *CommitFunc) Eval(ctx *sql.Context, row sql.Row) (interface{}, error) { | ||
| val, err := cf.Child.Eval(ctx, row) | ||
| dbName := ctx.GetCurrentDatabase() |
There was a problem hiding this comment.
Same comment about code duplication from the other PR applies here. Do another pass on this in the near future to consolidate.
Fix up tests fix commit tests.... Add author param to merge formatting... Fix array prob
VinaiRachakonda
force-pushed
the
vinai/add-commit-merge-params
branch
from
63c07c2
to
442ab7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMMIT('-m', 'hi', '--author', 'John Doe john@doe.com')
MERGE('feature-branch', '--author', 'John Doe john@doe.com')