go/libraries/doltcore/{doltdb,table}: remove row access methods from doltdb.Table #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-wm-arthur
force-pushed
the
andy/table-refactor
branch
from
16fd734
to
818e1a8
Compare
andy-wm-arthur
force-pushed
the
andy/table-refactor
branch
from
818e1a8
to
e31a599
Compare
andy-wm-arthur
commented
Dec 10, 2020
| @@ -105,7 +104,7 @@ func updateTableWithNewSchema(ctx context.Context, tblName string, tbl *doltdb.T | |||
| } | |||
|
|
|||
| err = rowData.Iter(ctx, func(k, v types.Value) (stop bool, err error) { | |||
| oldRow, _, err := tbl.GetRow(ctx, k.(types.Tuple), newSchema) | |||
| oldRow, err := row.FromNoms(newSchema, k.(types.Tuple), v.(types.Tuple)) | |||
There was a problem hiding this comment.
This is temporary for this change, we'll need a general purpose way to set defaults
zachmu
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed:
Had do to some refactoring along the way to fix dependency cycles.
Reversed dependency
rowconv -> pipelinetopipeline -> rowconv