Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README quotes changed bugfix for windows terminal #1111

Merged
merged 4 commits into from Dec 14, 2020

Conversation

VyasSathya
Copy link
Contributor

On the README there are instructions on how to add values into a table. The values in one portion have single quotes on the outside and have double-quotes for any string. While that format works in a Unix terminal, it doesn't work in Powershell or command prompt.

The results before and after the fix are here

BugInReadMe
FixedREADMECommand

A few notes:

  1. This issue only exists if the -q query is used, if dolt SQL is called by itself and the SQL query is called separately there is no problem.
  2. I tried to fix the code to see if there was a problem parsing it, but as I went up I found that the issue starts at main. If the quotes are single outside double inside then it will remove the quotes when it comes into args.

Copy link
Contributor

@bheni bheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bheni bheni merged commit b8eb7c3 into dolthub:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants