Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Andy/write feature version #1328

Merged
merged 27 commits into from Feb 19, 2021
Merged

Andy/write feature version #1328

merged 27 commits into from Feb 19, 2021

Conversation

andy-wm-arthur
Copy link
Contributor

@andy-wm-arthur andy-wm-arthur commented Feb 13, 2021 •
edited

FeatureVersion is now checked every time a RootVal is read, and is written with every call to doltdb.WriteRootValue().

A CLI flag was added to dolt.go to enable FeatureVersion testing.

@andy-wm-arthur
deduped dangling commit functions in doltdb
44d1514
@andy-wm-arthur
injecting feature version on commit
52d71ac
@andy-wm-arthur
added more versions to compatibility testing
bead12d
@andy-wm-arthur
update compat versions
c6be5ef
@andy-wm-arthur
support more versions
41e0711
@andy-wm-arthur
reverting feature version injection on commit
efd7d2f
@andy-wm-arthur
write feature version on TableEditSession.flush()
bf081d6
@andy-wm-arthur
added feature_version.md
b7402bb
@andy-wm-arthur
setup whitebox integration tests for feature version
acc3525
@andy-wm-arthur
feature version integration tests
8b79803
@andy-wm-arthur
refactored checkout to retain feature version data
db025df
@andy-wm-arthur
moved FeatureVersion validation into doltdb.newRootValue
ebdba47
@andy-wm-arthur
more tests, set feature version on merge and stage
866d5e6
@andy-wm-arthur
comment doc for RootValue.SetFeatureVersion()
0ab5ae1
@andy-wm-arthur
test fixes
bbd371e
@andy-wm-arthur
removed RootValue.SetFeatureVersion(), set FeatureVersion on every Do…
5f0c962 
…ltDb.WriteRootValue()
@andy-wm-arthur
write correct RootVal hash on clone
ccbf872
@andy-wm-arthur
added --feature-version flag to CLI
8fcb16f
@andy-wm-arthur
added bats for feature version
84b7596
@andy-wm-arthur
reduce scope of assert_feature_version
2d5f2ee
@andy-wm-arthur
refactored RootValueUnreadable to not swallow errors
9e40cc4
@andy-wm-arthur
assert FeatureVersion in BATS teardown
2056725
@andy-wm-arthur andy-wm-arthur marked this pull request as ready for review February 15, 2021 19:14
reltuk
reltuk approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

go/cmd/dolt/commands/version.go Outdated Show resolved Hide resolved
@andy-wm-arthur @reltuk
Update go/cmd/dolt/commands/version.go
dd833bd 
Co-authored-by: Aaron Son <aaron@dolthub.com>
@andy-wm-arthur andy-wm-arthur merged commit 10751ac into master Feb 19, 2021
@Hydrocharged Hydrocharged deleted the andy/write-feature-version branch March 2, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reltuk reltuk reltuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andy-wm-arthur @reltuk