fix infinite loop #1367
Merged
fix infinite loop #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Feb 24, 2021
| panic("overflow") | ||
| } | ||
|
|
||
| for minLength > length { |
There was a problem hiding this comment.
These loops seem like a strange way to ensure that length is bigger than minLength up to MaxUint32. Can't we just round up to the nearest half gig that's over the requested capacity?
There was a problem hiding this comment.
the bit twiddling approach to rounding to the next power of 2 isn't readable, and this isn't happening in a tight loop where this needs to be super fast so leaving the doubling loop.
If you a good way to round to the next half gig that works, feel free to suggest it. But I don't think it's more readable, and perf isn't a concern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if
length = length * 2overflowed before it was greater than the necessary sizeensureCapacitywould loop forever. After 2 gigs we allocate a half gig at a time and if the allocation size exceeds a uint32 we panic, rather than fail later.