Prevent server start if port in use

[yakkomajuri]

Closes #1160

• Adds a check to see if a port is already in use in the specified host and prevent sql-server from starting if that's the case
• Adds a test for this behavior

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[timsehn]

I'd love to see a bats test for this one.

[zachmu]

Hi @yakkomajuri ,

Can you add a test for this in the bats directory? You need to install bats to run the tests in that directory.

Also we need you to accept the CLA before we can accept this.

[yakkomajuri]

So sorry, I find the project super cool but I'm not comfortable signing the CLA.

Saw it on HN and immediately went into the codebase before checking the license, my apologies!

[zachmu]

Hi @yakkomajuri,

We have eliminated the CLA requirement if you still want to contribute this. Might need to open a fresh PR to spur GitHub into realizing that the CLA is gone.

[yakkomajuri]

Hey @zachmu! Sounds good, I'll try to give bats a look over the weekend and submit a new PR

[timsehn]

Thanks for prodding us on the CLA. We realized it was dumb because of this PR :-)

[timsehn]

Pinging here :-)

[yakkomajuri]

Hey @timsehn ! Thanks for the ping - I'm happy to resubmit the PR but not sure I'll get to bats too soon - been super super busy, so apologies for the delay!

[timsehn]

If you just fix the formatting with `repo_format` in `utils` we can write the bats for you :-)

…

On Wed, Apr 21, 2021 at 12:41 PM Yakko Majuri ***@***.***> wrote: Hey @timsehn <https://github.com/timsehn> ! Thanks for the ping - I'm happy to resubmit the PR but not sure I'll get to bats too soon - been *super super* busy, so apologies for the delay! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1394 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJAR3BJJDLCKHODV3Z2WTLTJ4S63ANCNFSM4YXZX45Q> .