Add few doltpy commands that broke with dolt compatibility changes #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsehn
reviewed
Mar 25, 2021
integration-tests/bats/doltpy.bats
Outdated
| # "SELECT * FROM `{table}` ASOF '{commit}'" | ||
|
|
||
| # verifying the output comparison to dolt log would be nice | ||
| @test "doltpy: Dolt.log" { |
There was a problem hiding this comment.
I think you should put the assertion in the test name. Like:
"dolt log returns proper named headers"
integration-tests/bats/doltpy.bats
Outdated
| ORDER BY date DESC | ||
| LIMIT 1; | ||
| SQL | ||
| echo $status |
There was a problem hiding this comment.
Get rid of theses. They are trapped if the test passes and you get output if it fails. echos are useless.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bats that if failed indicate a doltpy incompatibility. The tests could be more involved, but the goal here isn't row-output correctness.
This list will grow as I rewrite more dolt commands to use SQL features.