Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctx to WithFilters #1832

Merged
merged 2 commits into from Jun 15, 2021
Merged

ctx to WithFilters #1832

merged 2 commits into from Jun 15, 2021

Conversation

bheni
Copy link
Contributor

@bheni bheni commented Jun 15, 2021

No description provided.

@bheni bheni requested a review from zachmu June 15, 2021 19:55
zachmu
zachmu approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some type assertions if they don't already have it, otherwise LGTM

@bheni bheni merged commit 029bb5d into master Jun 15, 2021
@bheni bheni deleted the bh/ctx-for-withfilters branch June 15, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bheni @zachmu